CI: Fix checkpatch #497
Merged
CI: Fix checkpatch #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmilea
suggested changes
Jul 10, 2023
.github/workflows/compliance.yml
Outdated
| - name: Install python dependencies | ||
| run: | | ||
| pip3 install setuptools | ||
| pip3 install junitparser==1.6.3 gitlint codespell | ||
| pip3 install junitparser gitlint codespell lxml |
There was a problem hiding this comment.
Not mandatory: add python-magic to the list of python packages explicitly installed as a reference for check_compliance.py users. I don't think this happens on ubuntu-latest, so this action might work on github.
In a clean puthon3.11 virtual environment python-magic is also required, otherwise check_compliance.py fails.
./scripts/ci/check_compliance.py", line 20, in
import magic
ModuleNotFoundError: No module named 'magic'
Otherwise, good to merge.
The CI does not consider "check" reported by checkpatch. This commit fixes it by: - rebasing check_compliance.py compliance.yml to integrate Zephyr updates, - add detection of the "check" in the report. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
arnopo
force-pushed
the
Fix_checkpatch_CI
branch
from
6336449
to
6ebd300
Compare
|
Thanks for the update @arnopo . Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI does not consider "check" reported by checkpatch. This commit fixes it by:
An exemple of the result is available here: arnopo#25